Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix RGAT when inputs of rgat.forward have shape (0, x) #562

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

classicsong
Copy link
Contributor

Issue #, if available:
When inputs of RGAT.RelationalAttLayer have some node types with input shape (0, x). The module will crash.

Description of changes:
Fix the bug. More details please see tests/unit-tests/test_nn_model.py: test_rgat_with_zero_input

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@classicsong classicsong requested a review from zhjwy9343 October 16, 2023 06:40
@classicsong classicsong added bug Something isn't working ready able to trigger the CI 0.2.1 labels Oct 16, 2023
Copy link
Contributor

@zhjwy9343 zhjwy9343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@classicsong classicsong merged commit 18074f6 into awslabs:main Oct 16, 2023
6 checks passed
@classicsong classicsong deleted the fix-rgat branch October 16, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2.1 bug Something isn't working ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants